Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build matrix script #346

Merged
merged 6 commits into from Oct 7, 2018
Merged

Fix build matrix script #346

merged 6 commits into from Oct 7, 2018

Commits on Oct 7, 2018

  1. Remove req to run build-matrix locally from CONTRIBUTING 

    * The script has been broken for some time and there are no tests for it
to ensure that it keeps working.
* The script is rbenv-specific and it feels unfair to force contributors
to install a specific Ruby version manager.
* The build matrix is automatically run on Travis CI for all pull
requests anyway.
    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    5223926 View commit details
    Browse the repository at this point in the history

  2. Tweaks to wording in CONTRIBUTING

    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    cbbb8ed View commit details
    Browse the repository at this point in the history

  3. Add require statement to allow use of $CHILD_STATUS 

    Some versions of Ruby need this to be required.

See the 2nd error mentioned in this comment [1].

[1]: #343 (comment)
    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    ab7108c View commit details
    Browse the repository at this point in the history

  4. Improve output from build-matrix script

    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    45e9afa View commit details
    Browse the repository at this point in the history

  5. Skip builds in matrix when Ruby version not installed

    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    330e3f5 View commit details
    Browse the repository at this point in the history

  6. Update to latest bundler in build-matrix builds 

    This is equivalent to the `before_install` script in `.travis.yml`.
    @floehopper
    floehopper committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    9624f50 View commit details
    Browse the repository at this point in the history