[WIP] Fail fast if mocking before setup #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. outside the per-test lifecycle; e.g. RSpec's `before(:all)` blocks. In this commit a "Null Object" Mockery instance is set as the default and only replaced by the a real Mockery instance when `Hooks#mocha_setup` is called by the test framework, i.e. once the lifecycle of an individual test has started. The Mockery is now always explicitly built, rather than being lazily instantiated. Using a `StubbingError` filters the Mocha files out of the backtrace. I have not modified the existing tests nor added any new ones, so this will need some work before it can be merged into `master`. See #292 for more details.
floehopper
force-pushed
the
spike-fail-fast-if-mocking-before-setup
branch
from
b3106d6
to
1da71b9
Compare
floehopper
force-pushed
the
spike-fail-fast-if-mocking-before-setup
branch
from
6f43b95
to
f2556a0
Compare
|
Superseded by #327. Closing. |
|
This branch did not work for me, lemme try the new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work that came out of #292.
It needs more work before it can be merged, but I thought it was worth making it into a PR to highlight the work that has already been done.