Fix build matrix script #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The script has been broken for some time and there are no tests for it to ensure that it keeps working. * The script is rbenv-specific and it feels unfair to force contributors to install a specific Ruby version manager. * The build matrix is automatically run on Travis CI for all pull requests anyway.
Some versions of Ruby need this to be required. See the 2nd error mentioned in this comment [1]. [1]: #343 (comment)
This is equivalent to the `before_install` script in `.travis.yml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344.
build-matrixscript locally fromCONTRIBUTING.mdbuild-matrixscript so that it at least runs on my machine