Skip to content

Commit

Permalink
Disable Style/AccessModifierDeclarations for all files
Browse files Browse the repository at this point in the history
This cop was only introduced relatively recently and it seems to have
stirred up some controversy [1].

It was being triggered in many of the acceptance tests where anonymous
classes are defined within a test and their methods' visibility is
specified "inline".

[1]: rubocop/rubocop#5953
  • Loading branch information
floehopper committed Jul 26, 2018
1 parent 41a0563 commit 1e3eb74
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 4 additions & 0 deletions .rubocop.yml
Expand Up @@ -50,3 +50,7 @@ Style/WhileUntilModifier:
# frozen_string_literal magic comment has only been supported since Ruby v2.3
Style/FrozenStringLiteralComment:
Enabled: false

# This recently introduced cop seems to have stirred up some controversy
Style/AccessModifierDeclarations:
Enabled: false
6 changes: 0 additions & 6 deletions .rubocop_todo.yml
Expand Up @@ -83,12 +83,6 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity:
Max: 11

# Offense count: 97
# Configuration parameters: EnforcedStyle.
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
Enabled: false

# Offense count: 105
Style/Documentation:
Enabled: false
Expand Down

0 comments on commit 1e3eb74

Please sign in to comment.