Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds UI for managing an Album's License #173

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Adds UI for managing an Album's License #173

wants to merge 16 commits into from

Conversation

rosschapman
Copy link
Contributor

@rosschapman rosschapman commented Feb 19, 2024 •
edited

NOTE: This PR is inclusive of #167 and #172. Reviewers should wait until those PRs are merged first.

Considerations

  • The License relationship on the Album is optional
  • However, because there is no blank option on the form, any time an Album is edited it will automatically receive "All Rights Reserved" unless the person selects a different option.
  • This means once this code is checked in, all new albums will be created with a license.
  • 馃 I "designed" the data on the album screen to follow styling from attributes above it. So it basically just sits there. Does it need any additional copy for context? Maybe an icon?

After:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rosschapman