feat(recap): Add suport to parse ACMS attachment pages #3393
+372
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERosendo
changed the title
ERosendo
force-pushed
the
feat-add-support-to-parse-attachment-pages-from-acms
branch
3 times, most recently
from
7fb2719
to
a58920e
Compare
ERosendo
force-pushed
the
feat-add-support-to-parse-attachment-pages-from-acms
branch
from
a58920e
to
855aaf6
Compare
ttys0dev
reviewed
Nov 21, 2023
Adds a new parameter to the merge_attachment_page_data method and tweaks the merge mechanism to integrate ACMS attachment pages into their corresponding docket entries.
ERosendo
force-pushed
the
feat-add-support-to-parse-attachment-pages-from-acms
branch
2 times, most recently
from
0d221ca
to
4ae06ee
Compare
ERosendo
force-pushed
the
feat-add-support-to-parse-attachment-pages-from-acms
branch
from
4ae06ee
to
5214801
Compare
grossir
reviewed
Apr 24, 2024
* Updates logic to handle successful marking of the processing queue using the new method arguments. * Implements the `associate_related_instances` method for additional functionality.
|
@grossir, can you please review again before I take another look? It's been a month or two and it looks like we've got some changes. Thank you! |
grossir
reviewed
May 28, 2024
There was a problem hiding this comment.
I see that different UPLOAD_TYPES have different validations in ProcessingQueueSerializer.validate. Would it be worth it to add validations for ACMS_ATTACHMENT_PAGE and ACMS_DOCKET_JSON ?
| "docket_entry", "docket_entry__docket" | ||
| ) | ||
| .filter(**params) | ||
| .afirst() |
There was a problem hiding this comment.
Are you sure the first will be the desired RD? Note that the RecapDocument model has this Meta attribute ordering = ("document_type", "document_number", "attachment_number")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the logic to process attachment pages from ACMS. Here's a breakdown of the key changes:
New Upload Type: A new upload type named
ACMS_ATTACHMENT_PAGEis added to theProcessingQueueandpacerhtmlfilesmodel.A new helper method
process_recap_acms_appellate_attachmentis introduced. This method encapsulates the logic for parsing, processing, and merging ACMS attachment pages.The
PacerDocIdLookUpSerializerclass is updated to include theacms_document_guidfield in its response. This field is crucial for matching documents within the attachment page and generating the recap icon in ACMS.Factories are added to mock the dictionary returned by Juriscraper methods. Additionally, tests are included to verify the functionality of the new features.