Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ProcessingQueue document_number a CharField to match RECAPDocument #3385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ttys0dev
Copy link
Contributor

Leading zeros are significant so we shouldn't use BigIntegerField.

Should help with #2877.

@ttys0dev ttys0dev force-pushed the document-number-char branch 6 times, most recently from 270c241 to 2a5f89f Compare November 20, 2023 01:10
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick comment, but it's not for you, @ttys0dev. This looks fine otherwise though, thank you.

cl/recap/api_serializers.py Show resolved Hide resolved
Leading zeros are significant so we shouldn't use BigIntegerField.
@mlissner
Copy link
Member

I've added this to our deploy backlog. I'm working on hiring an engineer to take this on, because, well, evidence suggests that I'm failing to do so myself. Growing pains, sorry.

@mlissner
Copy link
Member

Eduardo, I'm putting this on your backlog somewhere. When it gets to the top, can you give this one more look and, assuming you approve, tune it up for Ramiro to deploy?

@ERosendo
Copy link
Contributor

@mlissner Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Deployments
Status: Main Backlog
Development

Successfully merging this pull request may close these issues.

None yet

3 participants