Management command to update the order of opinions #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it requires to change the AWS_STORAGE_BUCKET_NAME env variable to read files from private storage
…irectory with xml files
NOTE: functions found in columbia_utils.py and utils.py, were temporarily added in the command,when the necessary changes are combined we need to remove the functions and import them from the utils.
NOTE: functions found in columbia_utils.py and utils.py, were temporarily added in the command,when the necessary changes are combined we need to remove the functions and import them from the utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This management command will allow us to correctly order the opinions of Columbia or Harvard.
For harvard it's not that hard because those opinions were imported in the correct order, so we use the pk as a guide to establish the correct order.
For columbia it's a bit different because the opinions were imported by type as @flooie mentioned in issue #2499, to fix this i used some code from the new columbia importer(#2865) and some code from harvard merger to try to match the opinions from the cluster and the file (I extract the correct order by processing the file).
I'm still testing the command to see if i'm missing anything