updates due to CVE-2018-7753 and CVE-2018-5773 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkll
approved these changes
Jan 4, 2019
There was a problem hiding this comment.
Thanks for catching this and the fix @redshiftzero!
Due to my permissions on the repo I did not receive the GH alert, and the safety check did not catch this on the last run (presumably the database is not yet updated with this vuln: https://circleci.com/gh/freedomofpress/securedrop.org/1707 )
harrislapiroff
force-pushed
the
fix-security-warnings
branch
from
1a5e533
to
764b4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates due to GitHub security alerts:
CVE-2018-7753: updating bleach to at least 2.1.4 resolves (https://github.com/freedomofpress/securedrop.org/network/alert/requirements.txt/bleach/open)
CVE-2018-5773: The GitHub alert doesn't reflect this right now, but the project maintainer fixed in More robust XSS check trentm/python-markdown2#315, which was included in 2.3.7, so updating to this latest version should resolve.