Update PyYAML to 5.1 #24
Conversation
setup.py
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="securedrop-proxy", | |||
| version="0.1.2", | |||
| version="0.1.3", | |||
There was a problem hiding this comment.
the other place we'll want to bump the version is in the proxy Response here: https://github.com/freedomofpress/securedrop-proxy/blob/master/securedrop_proxy/proxy.py#L21
|
hey @kushaldas - want to do the diff/changelog review for these dependency updates? |
|
e56f799 lgtm! I just enabled builds from forks in Circle CI so that tests will run on next push |
Also simplify package versioning with a VERSION file containing the version string, e.g. 0.1.3, which will be read in setup.py and securedrop_proxy/version.py. Now we just have to remember to update the package version in one place. Add a test making sure that the proxy reports the same version used in setup.py.
|
To the diff/changelog reviewer: we reviewed pyyaml updates over in freedomofpress/securedrop-sdk#72 so the reviewer here just needs to verify the hashes are the same |
|
I am going to do the diff review here. |
|
@rmol @redshiftzero the update to PyYAML 5.1 is approved. The diff looks okay to me. https://github.com/freedomofpress/securedrop-debian-packaging/wiki/PyYAML-5.1 |
There was a problem hiding this comment.
verified same hashes as in freedomofpress/securedrop-sdk#72, diff otherwise looks good including version handling, thanks @rmol!
This change updates the PyYAML requirement to 5.1.
Fixes #134.