libnvmf: avoid resource leak #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @bsdjhb |
bsdimp
approved these changes
May 16, 2024
|
Tagged with 'ready' but I'll give it until tomorrow for @bsdjhb to take. peek |
|
The other error cases in the loop after the realloc all call free, so this is more consistent. |
bsdjhb
approved these changes
May 16, 2024
|
Would maybe s/first loop cycle/previous loop iteration/ in the log message. "again" might also be confusing as you aren't calling free multiple times, so I would perhaps omit it from the log message. |
khorben
force-pushed
the
khorben/cid-1545034
branch
2 times, most recently
from
a009674
to
fe3edfa
Compare
The |
bsdimp
pushed a commit
to concussious/freebsd-src
that referenced
this pull request
May 21, 2024
In nvmf_host_fetch_discovery_log_page(), the log variable may have been allocated on the heap during the first loop cycle, and should be free()'d before exiting upon errors. Reported by: Coverity CID: 1545034 Sponsored by: The FreeBSD Foundation Reviewed by: imp,jhb Pull Request: freebsd#1239
bsdimp
force-pushed
the
khorben/cid-1545034
branch
from
fe3edfa
to
1ea2f56
Compare
MFC after: 3 days Fixes: 286c490 (add -noauto), 3914ddf (import autofs) Pull Request: freebsd#1243 Reviewed by: imp Pull Request: freebsd#1243
Reviewed by: imp,jhb Pull Request: freebsd#1242
Reviewed by: imp,jhb Pull Request: freebsd#1241
In nvmf_host_fetch_discovery_log_page(), the log variable may have been allocated on the heap during the first loop cycle, and should be free()'d before exiting upon errors. Reported by: Coverity CID: 1545034 Sponsored by: The FreeBSD Foundation Reviewed by: imp,jhb Pull Request: freebsd#1239
bsdimp
force-pushed
the
khorben/cid-1545034
branch
from
1ea2f56
to
408572a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nvmf_host_fetch_discovery_log_page(), the log variable may have been allocated on the heap during a first loop cycle, and should be free()'d again before exiting upon errors.
Reported by: Coverity
CID: 1545034
Sponsored by: The FreeBSD Foundation