cp: avoid a resource leak #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdimp
reviewed
May 16, 2024
| @@ -112,6 +112,8 @@ copy_file(const FTSENT *entp, int dne) | |||
| if ((from_fd = open(entp->fts_path, O_RDONLY, 0)) < 0 || | |||
| fstat(from_fd, &sb) != 0) { | |||
| warn("%s", entp->fts_path); | |||
| if (from_fd >= 0) | |||
There was a problem hiding this comment.
You could just close it since you're casting away the return value anyway.
There was a problem hiding this comment.
I'd rather avoid calling close with an invalid fd, and am happy with the change as proposed
There was a problem hiding this comment.
OK. It would disturb errno, but the warn also could as well... but we're not super careful with errno in this code
In copy_file(), make sure the from_fd file descriptor is closed even when the operation failed early. Reported by: Coverity Scan CID: 1545036 Sponsored by: The FreeBSD Foundation Reviewed by: imp, emaste Pull Request: freebsd#1238
bsdimp
force-pushed
the
khorben/cid-1545036
branch
from
43288b5
to
3d7c8f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In copy_file(), make sure the from_fd file descriptor is closed even when the operation failed early.
Reported by: Coverity Scan
CID: 1545036
Sponsored by: The FreeBSD Foundation