Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it easier to make tags #435

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Feb 9, 2024

closes #385

@Sembauke Sembauke requested a review from a team as a code owner February 9, 2024 09:59
Copy link
Member

@sidemt sidemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!

There seems to be 2 issues:

  • When no maching tags were found, it only shows the message "No options found!". Could you change it to something like "Add {new tag name}" so it's easier to find that the user can add a new tag?
  • For example, if a tag JavaScript already exists, a new tag Java can't be added.

I haven't tried it myself, but the AutoCompleteCreatable component explained in this document seem to help:
https://www.npmjs.com/package/@choc-ui/chakra-autocomplete#creatable-items

Copy link
Member

@sidemt sidemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue!

I haven't understood the whole code, but there appears to be problems:

  • If there was an existing tag JavaScript and if you type Java, and then click "Create a tag named Java" in the select box, it doesn't create a new tag.
  • If there was an existing tag JavaScript and if you type Java, and then click JavaScript in the select box, it creates a new tag Java instead.

It's working as I expected when there is no matching tag. It's easier to add new tags, so I'm sure the editors will appreciate it!

@Sembauke
Copy link
Member Author

Hey @sidemt,

I did not know it was possible to use your mouse to add or create new tags. Would you like me to add this functionality? I have only implemented creation/adding through the keyboard. Which should work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to add a new tag
2 participants