Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): add challenges to block 4.3 of the English Curriculum #54776

Merged
merged 6 commits into from
May 20, 2024

Conversation

DanielRosa74
Copy link
Contributor

Checklist:

@DanielRosa74 DanielRosa74 requested a review from a team as a code owner May 14, 2024 00:04
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 14, 2024
@DanielRosa74 DanielRosa74 added the new english course English Curriculum label May 14, 2024
@DanielRosa74 DanielRosa74 requested a review from a team as a code owner May 16, 2024 18:47
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @DanielRosa74 🎉

In the tasks I mentioned on my review of 4.2, the audio was off significantly enough that I thought they should be checked again to try and make them better. I found a number of tasks in here where the audio was off, but not so much that they necessarily need to be changed. They were mostly only off by a tiny bit - I think it wouldn't be too bad if they made it to production like that, but here's a list of what I found:

Task 18 seemed a little long
Task 19 looked a little strange, the audio seemed mostly fine, but Sophie disappeared a little quick.
Task 26-27 start a little late - you don’t hear the whole first word

Task 28-29, 34, 39, 44, 46, 48, 53, 68, 69, 71, 72, 78, 85, 86 - cut off a little early

@DanielRosa74
Copy link
Contributor Author

This is looking good @DanielRosa74 🎉

In the tasks I mentioned on my review of 4.2, the audio was off significantly enough that I thought they should be checked again to try and make them better. I found a number of tasks in here where the audio was off, but not so much that they necessarily need to be changed. They were mostly only off by a tiny bit - I think it wouldn't be too bad if they made it to production like that, but here's a list of what I found:

Task 18 seemed a little long Task 19 looked a little strange, the audio seemed mostly fine, but Sophie disappeared a little quick. Task 26-27 start a little late - you don’t hear the whole first word
 Task 28-29, 34, 39, 44, 46, 48, 53, 68, 69, 71, 72, 78, 85, 86 - cut off a little early

Changes made, @moT01! Thanks for checking.

@DanielRosa74 DanielRosa74 requested a review from moT01 May 18, 2024 00:15
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@moT01 moT01 self-assigned this May 20, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@nieldakarla nieldakarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moT01 moT01 merged commit 72e1670 into freeCodeCamp:main May 20, 2024
22 checks passed
@DanielRosa74 DanielRosa74 deleted the feat/4.3-Dialogues branch May 20, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new english course English Curriculum platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants