-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(curriculum): add challenges to block 4.3 of the English Curriculum #54776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @DanielRosa74 🎉
In the tasks I mentioned on my review of 4.2, the audio was off significantly enough that I thought they should be checked again to try and make them better. I found a number of tasks in here where the audio was off, but not so much that they necessarily need to be changed. They were mostly only off by a tiny bit - I think it wouldn't be too bad if they made it to production like that, but here's a list of what I found:
Task 18 seemed a little long
Task 19 looked a little strange, the audio seemed mostly fine, but Sophie disappeared a little quick.
Task 26-27 start a little late - you don’t hear the whole first word
Task 28-29, 34, 39, 44, 46, 48, 53, 68, 69, 71, 72, 78, 85, 86 - cut off a little early
...iculum/challenges/_meta/learn-how-to-clarify-information-in-different-interactions/meta.json
Outdated
Show resolved
Hide resolved
...opers/learn-how-to-clarify-information-in-different-interactions/663c9a6ddd82d94fbe28bb08.md
Outdated
Show resolved
Hide resolved
Changes made, @moT01! Thanks for checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist:
main
branch of freeCodeCamp.