-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): api/users/get-public-profile #54729
Open
ojeytonwilliams
wants to merge
15
commits into
freeCodeCamp:main
Choose a base branch
from
ojeytonwilliams:feat/get-public-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(api): api/users/get-public-profile #54729
ojeytonwilliams
wants to merge
15
commits into
freeCodeCamp:main
from
ojeytonwilliams:feat/get-public-profile
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform: api
Server application that needs familiarity with Express, Loopback, MongoDB etc.
label
May 9, 2024
ojeytonwilliams
force-pushed
the
feat/get-public-profile
branch
2 times, most recently
from
May 16, 2024 11:01
46b56d6
to
9295054
Compare
moT01
added
the
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
label
May 20, 2024
The body is used for validation and so should care about format, length and so on. In contrast the response should not be validated because it would mix concerns (the handler is under our control and should not produce invalid output).
ShaunSHamilton
force-pushed
the
feat/get-public-profile
branch
from
May 24, 2024 09:53
4278798
to
53c3893
Compare
ShaunSHamilton
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Discussed in meeting: The new api returns is2018FullStackCert
, but the old api does not. Theoretically, this is a bug in the old api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: api
Server application that needs familiarity with Express, Loopback, MongoDB etc.
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
main
branch of freeCodeCamp.Post MVP, it would be nice if this just returned what get-session-user returns, but with the private properties null (or omitted). This would both clean up the code and make it clearer what the privacy toggles control.
Closes #54728