Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

feat: test saved tokens #2152

Merged
merged 13 commits into from
Jan 13, 2023
Merged

Conversation

gikf
Copy link
Member

@gikf gikf commented Dec 29, 2022

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Ref #1885


  • Adds ability to run test on saved (valid so far) tokens, via button in dashboard/calendar.
  • So far test tries to obtain from api calendarList.
  • Draft mainly because there's currently awkwardness while ensuring all valid tokens are tested, and the right token would be marked as invalid, if it fails. And as usual I'm a bit confused with the async looping.

@gikf gikf added UI/UX This issue deals with UI/UX API labels Dec 29, 2022
@ghost
Copy link

ghost commented Dec 29, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@gikf gikf marked this pull request as ready for review January 4, 2023 13:02
@gikf gikf requested a review from a team January 4, 2023 13:02
client/src/modules/dashboard/Calendar/pages/Calendar.tsx Outdated Show resolved Hide resolved
client/src/modules/dashboard/Calendar/pages/Calendar.tsx Outdated Show resolved Hide resolved
server/src/services/InitGoogle.ts Outdated Show resolved Hide resolved
server/src/services/InitGoogle.ts Outdated Show resolved Hide resolved
server/src/services/Google.ts Outdated Show resolved Hide resolved
gikf and others added 3 commits January 11, 2023 19:15
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@gikf
Copy link
Member Author

gikf commented Jan 11, 2023

@ojeytonwilliams Thanks, that makes things clearer and simpler.

@ojeytonwilliams
Copy link
Contributor

In case you're interested, I came across the 'trick' of avoiding naming things from Brian Will's youtube channel: https://www.youtube.com/@briantwill I forget which exactly which video, I'm afraid, but the channel as a whole is great.

Anyways, thanks for making those changes!

@ojeytonwilliams ojeytonwilliams enabled auto-merge (squash) January 13, 2023 13:56
@ojeytonwilliams ojeytonwilliams merged commit 8e35057 into freeCodeCamp:main Jan 13, 2023
@gikf
Copy link
Member Author

gikf commented Jan 14, 2023

Thanks, I think I found that portion in https://www.youtube.com/watch?v=2-G5WTghjYk avoid naming as much as possible. Other interesting insights as well 🚀

@gikf gikf deleted the feat/test-saved-tokens branch January 14, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API status: ready for review UI/UX This issue deals with UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants