This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 358
feat: test saved tokens #2152
Merged
ojeytonwilliams
merged 13 commits into
freeCodeCamp:main
from
gikf:feat/test-saved-tokens
Jan 13, 2023
Merged
feat: test saved tokens #2152
ojeytonwilliams
merged 13 commits into
freeCodeCamp:main
from
gikf:feat/test-saved-tokens
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👇 Click on the image for a new way to code review
Legend |
ojeytonwilliams
suggested changes
Jan 9, 2023
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@ojeytonwilliams Thanks, that makes things clearer and simpler. |
In case you're interested, I came across the 'trick' of avoiding naming things from Brian Will's youtube channel: https://www.youtube.com/@briantwill I forget which exactly which video, I'm afraid, but the channel as a whole is great. Anyways, thanks for making those changes! |
ojeytonwilliams
approved these changes
Jan 13, 2023
Thanks, I think I found that portion in https://www.youtube.com/watch?v=2-G5WTghjYk avoid naming as much as possible. Other interesting insights as well 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md
).main
branch of Chapter.Ref #1885
dashboard/calendar
.calendarList
.Draft mainly because there's currently awkwardness while ensuring all valid tokens are tested, and the right token would be marked as invalid, if it fails. And as usual I'm a bit confused with the async looping.