Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Marked #477

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Update Marked #477

merged 3 commits into from
Jun 25, 2019

Conversation

k-utsumi
Copy link
Contributor

Update Marked package as markdown does not work as expected.

e.g.

<details>

```
foo
```
</details>

@Chapabu
Copy link
Member

Chapabu commented Nov 21, 2018

Thanks for this! It looks OK, I'm just curious as to the reason why we have to "fix" the code renderer? I'm not saying we don't have to, it would just be good to understand why before this gets merged.

@Chapabu
Copy link
Member

Chapabu commented Dec 19, 2018

@k-utsumi Could you answer the above if you get a chance? I'm apprehensive to merge without knowing why we're making this change.

@k-utsumi
Copy link
Contributor Author

I'm sorry to reply late.
If you can wait, I want to update Marked once again with resolving Issue like markedjs/marked#1374

The reason for updating Marked is to facilitate the transfer of the document writing tool.
I think fractals are very useful, but others may not think so.
So I think ease of transfer is important.

@k-utsumi
Copy link
Contributor Author

k-utsumi commented Feb 1, 2019

@Chapabu
I updated this & fix style for mandelbrot.
frctl/mandelbrot#79

@stale
Copy link

stale bot commented Apr 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Apr 2, 2019
@k-utsumi
Copy link
Contributor Author

k-utsumi commented Apr 2, 2019

👀

@k-utsumi
Copy link
Contributor Author

@Chapabu Is it not okay?

@Chapabu Chapabu merged commit 66bd93a into frctl:develop Jun 25, 2019
@Chapabu
Copy link
Member

Chapabu commented Jun 25, 2019

Sorry for the delay with this one! Thank you for your contribution :)

@k-utsumi k-utsumi deleted the update-marked branch June 26, 2019 01:07
@jwir3 jwir3 mentioned this pull request Nov 13, 2019
1 task
LeBenLeBen added a commit to frctl/mandelbrot that referenced this pull request Jan 11, 2020
mihkeleidast pushed a commit that referenced this pull request May 21, 2020
mihkeleidast pushed a commit that referenced this pull request May 21, 2020
mihkeleidast pushed a commit that referenced this pull request May 23, 2020
mihkeleidast pushed a commit that referenced this pull request May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants