Fix mock.withArgs using matchers (sinonjs#1961)

Fixes sinonjs#1960
franck-romano · Oct 1, 2019 · 1accb3a · 1accb3a
1 parent 0fe19dc
commit 1accb3a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/sinon/mock.js b/lib/sinon/mock.js
@@ -37,7 +37,7 @@ function arrayEquals(arr1, arr2, compareLength) {
     }
 
     return every(arr1, function(element, i) {
-        return deepEqual(element, arr2[i]);
+        return deepEqual(arr2[i], element);
     });
 }
 

diff --git a/test/mock-test.js b/test/mock-test.js
@@ -653,6 +653,20 @@ describe("sinonMock", function() {
                     { name: "ExpectationError" }
                 );
             });
+
+            it("should not throw when expectation withArgs using matcher", function() {
+                var obj = {
+                    foobar: function() {
+                        return;
+                    }
+                };
+                var mock = sinonMock(obj);
+                mock.expects("foobar").withArgs(match.string);
+
+                refute.exception(function() {
+                    obj.foobar("arg1");
+                });
+            });
         });
 
         describe(".withExactArgs", function() {