Wrap safeToRemove function with useCallback hook #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Most React users use lint for hook which shows error when deps of
useEffectis missed. So,safeToRemovefunction need to be inserted intouseEffectwhen usinguseAnimatehook. Even if framer guide shows example code that is not includingsafeToRemoveinto deps ofuseEffect, react user want to solve lint error.Solution
Therefore,
safeToRemoveshould ensure that it keeps reference of same function in same component. If this is intended implementation, I would appreciate it if you explain the reason.Thanks for reading and your great library!