New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inertia: take care of the case when t is zero #2264
base: main
Are you sure you want to change the base?
Conversation
Is it possible to add a test on |
@mattgperry Thank you for your comment and indeed. Just addressed here. Please let me know! |
Is there an update on this PR? Having issues with reorders as well |
@ekatzenstein their is this PR #2231 waiting to be merged as well |
Is there anything blocking getting this merged in? It seems like a high impact, edge case fix that includes a test |
Shouldn't this be merged? It looks like a very simple fix that is tested. Or maybe I am missing something? |
Is there an update on this? I'm also having similar issues with reordering |
@mattgperry any chance we could have these 2 PRs merged please? The issue has been affecting our production for a while too |
Seeing the recent activity, I am bringing this PR up again! @mattgperry it is the last brik to fix the re-order component that is broken! |
Should this PR be merged or closed? |
This PR aims to fix an issue where
Reorder.Item
randomly gets stuck as I posted here.Related:
As noted here:
which means that
startTime
possibly can be equal tocurrentTime
andt
is 0 in that case.inertia
returns the state withdone: true
in that case, and stops the animation immediately.