Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multidimensional reorder #1862

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented Jan 3, 2023

This PR adds multidimensional reordering to Reorder components.

Continuation of #1685
Fixes #1400

cjoecker and others added 9 commits January 3, 2023 09:57
* add multidimensional sorting

* fix tests

* refactor naming

* add TODO

* remove items per axis

* add new observer

* add max-height to column sort

* remove unused comments

* add observer disconnection

* add observer disconnection

* add external ref

* fix error if there is only one item

Co-authored-by: Christian Jöcker <christian.joecker@maibornwolff.de>
Co-authored-by: Matt Perry <mattgperry@gmail.com>
)

if (itemLayout![crossAxis].min > prevItemLayout![crossAxis].min) {
itemsPerAxis = i // Should this not be + 1?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 [ 0 ] [ 1 ] [ 2 ]
 [ 3 ] 

Since the iteration starts on one, but looks back for 0, I think this is accurate as itemsPerAxis = i, because the value should be 3 in this example right? (0, 1, 2)

@heldervilela
Copy link

Hi there!
Any plans to merge the PR in the near future?

@giladgray
Copy link

echoing the previous comment, any update here?
this seems nearly ready to go and it would really supercharge the Reorder component!

@staranbeer
Copy link

@mattgperry Hey! Are there any plans to merge this PR any time soon?

@adamseckel
Copy link
Collaborator

Hey all, Matt is on paternity leave and will be able to consider this when he's back in a few weeks time! 😊

@staranbeer
Copy link

Congratulations @mattgperry 😄 ! Thanks for letting us know @Hemlok !

@varseb
Copy link

varseb commented Jul 20, 2023

Hello guys, do we have any update on this? that would be really nice to have this feature production ready 😃

@Espen92
Copy link

Espen92 commented Sep 7, 2023

Looks great, hoping to see this soon!

@vipuljbhikadiya
Copy link

@42arch hi do we have any plan to merge this PR or will take long ?

@nodegin
Copy link

nodegin commented Nov 7, 2023

This is really needed

@piszczu4
Copy link

Waiting for this!

@Fireclunge
Copy link

Bump! This would be awesome

@javiio
Copy link

javiio commented Jan 9, 2024

Waiting for this! Really needed

@JohnRubado
Copy link

Excited for this feature, should we expect this soon?

@Steinagel
Copy link

Can't wait for it! Really need it.

@alexanderhorner
Copy link

Any updates on this? Would be very helpful.

@ziadsabillah
Copy link

any updates?

@wiscaksono
Copy link

MERGE THIS SOON!!!

@ImZaryab
Copy link

Merge this ASAP please!

@Fireclunge
Copy link

I posted here nearly 3 months ago and ended up just using dnd-kit which I would really recommend - especially if you're not already tied to framer

https://www.npmjs.com/package/@dnd-kit/sortable

@sergnek
Copy link

sergnek commented Mar 24, 2024

let's merge!

@jxnnyo
Copy link

jxnnyo commented Apr 15, 2024

any plans on this getting merged?

@jxnnyo
Copy link

jxnnyo commented Apr 15, 2024

@mattgperry

@joi-lightyears
Copy link

Hi, any update on this, I need multi reorder in my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Multi-axis support in Reorder.Group