Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mijn omgeving overzicht pagina #436

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Mijn omgeving overzicht pagina #436

wants to merge 97 commits into from

Conversation

Marwaxhello
Copy link
Contributor

Om in je 'Mijn-omgeving' pagina te komen moet je eerst "fake" inloggen met je DigiD. Ik heb gekeken naar de 'wmebv' map en heb de stappen nagemaakt en gerefactored in mijn inlogpagina's van 'Mijn Omgeving'. Ik heb de component-libary-react en de dist/index.css toegevoegd aan mijn paginas. Ik heb ook opmerkingen toegevoegd aan mijn code met vragen over specifieke zaken die ik niet helemaal begrijp. Op die manier hoop ik meer aandacht te krijgen voor die punten, zodat ik antwoorden kan krijgen.
De oude code :

import type { Metadata } from 'next';

export const metadata: Metadata = {
  title: 'Mijn Omgeving Inloggen',
  description: '...',
};

const Page = () => {
  return (
    <div>
      <h1>Mijn Omgeving</h1>
    </div>
  );
};

export default Page;

staat nu als een comment en laat ik voor de volgende keer!

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gemeentevoorbeeldnl ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 8:34am

TessaViergever
TessaViergever reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@TessaViergever TessaViergever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, ik heb ernaar gekeken en wat comments achter gelaten 😄

Marwaxhello
Marwaxhello commented May 7, 2024
View reviewed changes
Copy link
Contributor Author

@Marwaxhello Marwaxhello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alleen nog name changes

packages/next-templates/src/components/Card/card.css
--example-card-border-color: var(--voorbeeld-color-dark-alpha-100);
--example-card-title-font-size: var(--voorbeeld-typography-font-size-xl);
--example-card-title-line-height: var(--voorbeeld-typography-line-height-lg);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card CSS example to voorbeeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessaViergever TessaViergever TessaViergever left review comments

@scar055 scar055 scar055 requested changes

@Robbert Robbert Awaiting requested review from Robbert

@ryanvvalkenhoef ryanvvalkenhoef Awaiting requested review from ryanvvalkenhoef

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Marwaxhello @Robbert @scar055 @TessaViergever