Don't silently execute statements on migrations when they can't be re…

…versed

Fixes rails#51570.

activerecord/CHANGELOG.md

@@ -1,3 +1,9 @@
+*   Don't silently execute statements on migrations when they can't be reversed.
+
+    Fixes #51570.
+
+    *Rafael Mendonça França*
+
 *   Allow `Sqlite3Adapter` to use `sqlite3` gem version `2.x`
 
     *Mike Dalessio*

activerecord/lib/active_record/migration/command_recorder.rb

@@ -376,9 +376,10 @@ def respond_to_missing?(method, _)
           super || delegate.respond_to?(method)
         end
 
-        # Forwards any missing method call to the \target.
+        # Forwards any missing method call to the target.
         def method_missing(method, ...)
           if delegate.respond_to?(method)
+            record(method, ...)
             delegate.public_send(method, ...)
           else
             super

activerecord/test/cases/migration/command_recorder_test.rb

@@ -46,12 +46,18 @@ def test_inverse_of_raise_exception_on_unknown_commands
         assert_raises(ActiveRecord::IrreversibleMigration) do
           @recorder.inverse_of :execute, ["some sql"]
         end
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.inverse_of :update, ["some sql"]
+        end
       end
 
       def test_irreversible_commands_raise_exception
-        assert_raises(ActiveRecord::IrreversibleMigration) do
+        x = assert_raises(ActiveRecord::IrreversibleMigration) do
           @recorder.revert { @recorder.execute "some sql" }
         end
+        assert_raises(ActiveRecord::IrreversibleMigration) do
+          @recorder.revert { @recorder.update "some sql" }
+        end
       end
 
       def test_record