Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

macOS automatic updates are broken for v0.16 - v0.17 #1878

Closed
amacneil opened this issue Sep 16, 2021 · 2 comments
Closed

macOS automatic updates are broken for v0.16 - v0.17 #1878

amacneil opened this issue Sep 16, 2021 · 2 comments
Assignees
Labels
bug The user is unable to complete a supported task, or the software does not behave as intended

Comments

@amacneil
Copy link
Contributor

Description
via @defunctzombie:

Checking for macOS Rosetta environment
Checked for macOS Rosetta environment (isRosetta=false)
updater cache dir: /Users/roman/Library/Application Support/Caches/foxglove-studio-updater
Update has already been downloaded to /Users/roman/Library/Application Support/Caches/foxglove-studio-updater/pending/foxglove-studio-0.18.0-mac-universal.zip).
Creating proxy server for native Squirrel.Mac (fileToProxy=https://github.com/foxglove/studio/releases/download/v0.18.0/foxglove-studio-0.18.0-mac-universal.zip)
Error: TypeError: Cannot read property 'port' of null
    at O (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37873)
    at n.updateDownloaded (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37959)
    at Object.done (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37457)
    at V (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:29470)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async n.executeDownload (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:29598)
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
TypeError: Cannot read property 'port' of null
    at O (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37873)
    at n.updateDownloaded (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37959)
    at Object.done (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:37457)
    at V (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:29470)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async n.executeDownload (/Applications/Foxglove Studio.app/Contents/Resources/app.asar/main/main.js:67:29598)
  • Version: Since around v0.17?
  • OS: macOS
@amacneil amacneil added the bug The user is unable to complete a supported task, or the software does not behave as intended label Sep 16, 2021
@defunctzombie
Copy link
Contributor

@jtbandes
Copy link
Member

Tested in dev mode by creating .webpack/dev-app-update.yml with:

provider: github
owner: foxglove
repo: studio

Confirmed that with electron-updater@4.4.5, I see the port error in console. With 4.3.9, which I accidentally downgraded to in https://github.com/foxglove/studio/pull/1776/files, the error is not present. With 4.6.0, the version we are currently using as of #1849, the error is also not present.

@amacneil amacneil changed the title macOS automatic updates are broken macOS automatic updates are broken for v0.16-v0.17 Sep 16, 2021
@amacneil amacneil changed the title macOS automatic updates are broken for v0.16-v0.17 macOS automatic updates are broken for v0.16 - v0.17 Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug The user is unable to complete a supported task, or the software does not behave as intended
Development

No branches or pull requests

3 participants