-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix & update dependencies #11119
Conversation
We actually support jQuery `>= v2.2.0` and what-input `>= v4.1.0`. There is no point with using the "minor only" selector for dependencies when we do support older versions.
Node v6.4.0 is required by `puppeteer` in `mocha-headless-chrome`. All others packages works with Node v4.0
|
@DanielRuf This was set by |
Got a few of these:
Because of sha512 hashes but I guess sha1 is still used by default by npm. |
|
|
The ajv issue might be an npm issue, see ajv-validator/ajv#708 |
|
|
We have to update the gulp tasks as |
Fixed the wrongly calculated basePath of gulp-cache-bust. Also see furzeface/gulp-cache-bust#17 I did not update all Gulp tasks but we may have to do it. |
@DanielRuf Thanks ! Did you checked changelogs or just repaired where there were errors ? |
I got this error when switching between branch without reinstalling packages. Sometimes NPM do not reinstall everything and I have to delete |
Just checked the changes based on the current readme. Will check all now. |
I can take care of the migrations. Please just update "DevDependencies migrations" with the changes you already made. |
Getting |
I cannot reproduce it :/ |
Did you scroll a bit and then reload the page? Got it at least there but can also test later today again if it is still relevant. |
Ok I can reproduce it. |
At least I saw it in the chats with @hal869 |
Changes: * add required `mode` option. Use "development" mode as optimization are handled by others gulp plugins. * use `webpack` instead of `webpack2` * remove stats about chunks (set as true by default in webpack 4)
Done.
|
Steps: 1. Install packages with Yarn, generating `yarn.lock` with sha1 integrity hashs (sha256/512 used by NPM is not supported by Yarn) 2. Generate `package-lock.json` alone with `npm i --package-lock-only` Resolved dependencies should be the sames but with the perfect lockfile format for each package manager.
078bdbf
to
dce21c1
Compare
The magellan bug is not caused by this PR. I can reproduce it on |
Sure, just wanted to mention it and my other findings. |
@DanielRuf See #11142 |
I'll delay this to an other PR as there is some bugs I would like to resolve in Motion-UI before a release, and Dependabot is not happy with our dependencies still out-of-dates. @DanielRuf Could you make a final review ? |
We could also update to webpack 4.5 probably ;-) Ok, will do so. |
True. |
No changes required
Updated dependencies:
Changes are only deprecation of node 4, bug fixes and new features. No migration is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled without any issues and kitchensink works. 👍
Thanks @DanielRuf for the review. Good to merge. For now dependencies will be kept up-to-date by Dependabot (thx @dependabot) |
As gulp sequences don't return a stream, a callback must be called when its callback job is done. Bug was introduced in foundation#11119
…es for v6.5.0 201d702 chore: use permissive selector for all compatible dependencies versions fb33cee chore: switch to be04444 chore: update all devDependencies to latest versions dd52875 chore: update dependencies lockfiles b5c95a8 docs: update required node version to 6.4.0 a14dc5c fix: set basePath for gulp-cache-bust and apply run-sequence 6144786 fix: use callback function in test tasks 2abca4a chore: fix indentation 531b006 chore: migrate more gulp tasks to new run-sequence API 205c352 chore: migrate gulp watch tasks to new run-sequence API 9529392 chore: remove unused devDependencies d09fbc3 chore: migrate to webpack 4 dce21c1 chore: regenerate yarn/npm lockfiles separately 5d24801 chore: enforce packages resolution via HTTPS 1e10055 chore: update dependencies (10-04-17) Co-Authored-By: Daniel Ruf <daniel@daniel-ruf.de> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
📦 Fix & update package versions:
We actually support jQuery
>= v2.2.0
and what-input>= v4.1.0
. There is no point with using the "minor only" selector for dependencies when we do support older versions. See Dependencies migrations below.Using David CLI. See DevDependencies migrations below.
Remove
process-nextick-args
,gulp-ruby-sass
andvinyl-source-stream
Using Synp to get synchronized lockfilesInstall depedencies with
yarn
(foryarn.lock
) then generatepackage-lock.json
withnpm i --lock-file-only
. Locked dependencies should be the sames but with the perfect lockfile format for each package manager.v6.4.0
Node v6.4.0 is required by
puppeteer
inmocha-headless-chrome
. All others packages works with Node v4.0🚀 New packages:
babel-plugin-*
tobabel-preset-env
,vinyl-source-stream
This is now the recommended way to deal with babel plugins. This is better than simply updating babel plugins.
📝 Dependencies changelogs
>=3.0.0
->>=2.2.0
(locked at3.3.1
)There should not be any impact since Foundation was compatible with v2.2.0 all along. See https://jquery.com/upgrade-guide/3.0/#browser-support for reference.
^4.1.3
->>=4.1.3
(locked at5.0.5
)No migration needed. See https://github.com/ten1seven/what-input#changes-from-v4.
📝 DevDependencies migrations
old version
->new version
the changes you made to migrate to the new version, if any
url to the release notes
^6.7.7
->^8.2.0
^1.1.1
->^2.3.2
^1.7.1
->^2.0.0
Rename
Clipboard
toClipboardJS
(see: fix: migrate to the new ClipboardJS instantiation to resolve conflict… foundation-docs#33)Changelog: https://github.com/zenorocha/clipboard.js/releases/tag/v2.0.0
^2.6.0
->^4.1.0
^0.2.0
->^1.0.0
^6.1.1
->^7.0.1
~1.0.2
->^1.3.0
Set the
basePath
option to target the used paths as required from v1.1.0Changelog: https://github.com/furzeface/gulp-cache-bust/releases/tag/1.1.0
^4.0.0
->^5.1.0
^0.2.0
->^1.0.1
^0.5.4
->^0.6.1
^0.0.7
->0.0.8
gulp-ruby-sass^2.0.6
-> removed^2.1.0
->^v4.0.1
^2.1.2
->^3.0.0
^3.2.0
->^4.1.0
^2.0.0
->^5.2.0
^3.4.2
->^5.0.5
^1.8.2
->^1.8.3
process-nextick-args^1.0.7
-> removed^0.3.2
->^1.0.0
^1.1.4
->^2.2.1
Migrate all tasks to the new run-sequence API to ensure that the tasks are run in the right order
Changelog: https://github.com/OverZealous/run-sequence/blob/master/CHANGELOG.md
^2.2.2
->^4.0.0
3.0.0
->^3.0.1
^1.17.7
->^4.5.0
^1.0.0
->^3.1.0
vinyl-source-stream^1.1.0
-> removed3.5.5
->^4.5.0
Set new
mode
option todevelopment
^3.2.0
->^4.0.3
^6.6.0
->^11.0.0
Update Motion-UI for Resolvesdelayed to an other PR.Passing a string to call()
deprecation warning for Sass 4.0 motion-ui#100