bump grpc and prep for 1.63.7 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in replacement for grpc.Dial()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
========================================
- Coverage 74.5% 74.4% -0.1%
========================================
Files 25 25
Lines 6186 6186
========================================
- Hits 4609 4605 -4
- Misses 1415 1418 +3
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
|
not sure what's up with coverage drop by ~ 10% but seems to be go1.22 related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tbd (ie tests results) for whether NewClient() is a drop… in replacement for grpc.Dial()Edit: looks like
grpc.NewClientisn't a drop in replacement forgrpc.Dialso keeping the working one for now