Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error reporting of timeout when getting invalid response, switch build to go 1.22.2 #914

Merged
merged 6 commits into from Apr 3, 2024

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Apr 3, 2024

Fixes #913 relies on fortio/log#60

Also bump go version in build image as 1.22.2 (and 1.21.9) were just released

tested using the bad server from #913 (comment)

and

go run . load -c 1 -n 2 localhost:3000

before

10:01:03.409 [ERR] Read error, err={"Op":"read","Net":"tcp","Source":{"IP":"127.0.0.1","Port":59061,"Zone":""},"Addr":{"IP":"127.0.0.1","Port":3000,"Zone":""},"Err":{}}, size=107, dest={"IP":"127.0.0.1","Port":3000,"Zone":""}, url="http://localhost:3000/foo", thread=0, run=0

after

12:56:28.318 r1 [ERR] http_client.go:1096> Timeout error (incomplete/invalid response), err="read tcp 127.0.0.1:63786->127.0.0.1:3000: i/o timeout", size=107, header_len=0, dest={"IP":"127.0.0.1","Port":3000,"Zone":""}, url="http://localhost:3000", thread=0, run=0

add header_len so it's easier to tell that CR+LF wasn't yet found and explicit message for timeout as well

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.8%. Comparing base (1a5a8ba) to head (6aa079b).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #914   +/-   ##
======================================
  Coverage    88.8%   88.8%           
======================================
  Files          17      17           
  Lines        5028    5034    +6     
======================================
+ Hits         4466    4472    +6     
  Misses        414     414           
  Partials      148     148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldemailly ldemailly changed the title fix error reporting of timeout when getting invalid response fix error reporting of timeout when getting invalid response, switch to go 1.22.2 Apr 3, 2024
@ldemailly ldemailly changed the title fix error reporting of timeout when getting invalid response, switch to go 1.22.2 fix error reporting of timeout when getting invalid response, switch build to go 1.22.2 Apr 3, 2024
Copy link

@tejaspbajaj tejaspbajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@ldemailly ldemailly merged commit a184337 into master Apr 3, 2024
9 checks passed
@ldemailly ldemailly deleted the bad_server branch April 3, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants