Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release readme for new shared workflows #910

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Update release readme for new shared workflows #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4c4a10
Update release readme for new shared workflows
ldemailly Mar 24, 2024
15bfb14
build-push-action is v5 (update outdated pin comment)
ldemailly Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
echo "Version $VERSION, Package version $PACKAGE_VERSION"

- name: Build and push Docker image
uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0 # pin@v3
uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0 # pin@v5
with:
context: .
platforms: linux/amd64,linux/arm64,linux/ppc64le,linux/s390x
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# linter config now comes from shared workflows
.golangci.yml
coverage.out*
tmp/
coverage.txt
*.bak
Expand Down
1 change: 0 additions & 1 deletion codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ coverage:
round: nearest # how coverage is rounded: down/up/nearest
ignore: # files and folders that will be removed during processing
- "**.pb.go"
- "dflag/test_utils.go"
8 changes: 4 additions & 4 deletions release/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# How to make a fortio release

- All the builds and docker, except the build image updates, are now fully automated through github actions based on tags
- All the builds and docker, except the build image updates, are now fully automated through github actions based on tags and most if shared from org wide https://github.com/fortio/workflows#workflows except for goreleaser which isn't used here and we maintain our own build image (see for instance fortiotel for newer build fully using the shared workflows)

- Make sure to use the same git tag format (e.g "v0.7.1" - note that there is `v` prefix in the tag, like many projects). Docker and internal version/tag is "0.7.1", the `v` is only for git tags.

Expand All @@ -22,7 +22,7 @@

- To update the command line flags in the ../README.md; run the new `release/bumpRelease.sh 1.53.0` for instance

- Update the homebrew tap `brew bump-formula-pr --tag v1.2.3 fortio`
- Update the homebrew tap `brew bump-formula-pr --tag v1.2.3 fortio` (brew team usually does this fairly often on their own)


## How to change the build image
Expand Down Expand Up @@ -50,8 +50,8 @@ make update-build-image-tag SED=gsed

Check the diff and make lint, webtest, etc and PR

Regularly update pinned github actions
using https://github.com/mheap/pin-github-action
Dependabot will regularly update pinned github actions - to pin a new dependency:
Use https://github.com/mheap/pin-github-action
```
npm install -g pin-github-action
```
Expand Down