-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using (partially) the shared workflows #908
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
======================================
Coverage 88.8% 88.8%
======================================
Files 17 17
Lines 5028 5028
======================================
Hits 4466 4466
Misses 414 414
Partials 148 148 ☔ View full report in Codecov by Sentry. |
looking at why the coverage dropped, it seems it's not doing the rerun with debug on or some such (not counting debug only lines) |
seems to have to do with atomic coverage though... that seems like a bug |
so -race is what removes the debug lines... somehow... anyway... fixed through fortio/workflows#10 |
Like done in many other fortio repos over last 2 days, use https://github.com/fortio/workflows
but keep the build using the fortio build image and not goreleaser
Introduced a shared action for checkout+qemu+docker login+docker buildx shared between releaser workflow and here
https://github.com/fortio/workflows/blob/main/.github/actions/common_setup/action.yml
This will eliminate most of the dependabot PRs except docker/build-push-action and action/create-release
(which are only used here)
also switched coverage to be same with added
dependencies
step in workflows/