Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using (partially) the shared workflows #908

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Using (partially) the shared workflows #908

merged 7 commits into from
Mar 23, 2024

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Mar 22, 2024

Like done in many other fortio repos over last 2 days, use https://github.com/fortio/workflows
but keep the build using the fortio build image and not goreleaser

Introduced a shared action for checkout+qemu+docker login+docker buildx shared between releaser workflow and here

https://github.com/fortio/workflows/blob/main/.github/actions/common_setup/action.yml

This will eliminate most of the dependabot PRs except docker/build-push-action and action/create-release
(which are only used here)

also switched coverage to be same with added dependencies step in workflows/

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.8%. Comparing base (757e321) to head (8b368fd).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #908   +/-   ##
======================================
  Coverage    88.8%   88.8%           
======================================
  Files          17      17           
  Lines        5028    5028           
======================================
  Hits         4466    4466           
  Misses        414     414           
  Partials      148     148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldemailly
Copy link
Member Author

looking at why the coverage dropped, it seems it's not doing the rerun with debug on or some such (not counting debug only lines)

@ldemailly
Copy link
Member Author

looking at why the coverage dropped, it seems it's not doing the rerun with debug on or some such (not counting debug only lines)

seems to have to do with atomic coverage though... that seems like a bug

@ldemailly
Copy link
Member Author

looking at why the coverage dropped, it seems it's not doing the rerun with debug on or some such (not counting debug only lines)

seems to have to do with atomic coverage though... that seems like a bug

so -race is what removes the debug lines... somehow... anyway... fixed through fortio/workflows#10

@ldemailly ldemailly merged commit 7fb7162 into master Mar 23, 2024
9 checks passed
@ldemailly ldemailly deleted the shared_workflows branch March 23, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants