Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for setting grpc metadata #671

Merged
merged 17 commits into from
Jan 13, 2023
Merged

add support for setting grpc metadata #671

merged 17 commits into from
Jan 13, 2023

Conversation

ktalg
Copy link
Collaborator

@ktalg ktalg commented Dec 18, 2022

Closes #663

README.md Outdated Show resolved Hide resolved
fgrpc/pingsrv.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 88.6% // Head: 88.7% // Increases project coverage by +0.1% 🎉

Coverage data is based on head (a1c9147) compared to base (a2dbeac).
Patch coverage: 100.0% of modified lines in pull request are covered.

❗ Current head a1c9147 differs from pull request most recent head 58cfdd8. Consider uploading reports for the commit 58cfdd8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #671     +/-   ##
========================================
+ Coverage    88.6%   88.7%   +0.1%     
========================================
  Files          30      30             
  Lines        4368    4395     +27     
========================================
+ Hits         3871    3898     +27     
  Misses        331     331             
  Partials      166     166             
Impacted Files Coverage Δ
fhttp/http_client.go 84.3% <ø> (ø)
fgrpc/grpcrunner.go 90.7% <100.0%> (+1.2%) ⬆️
fgrpc/pingsrv.go 89.8% <100.0%> (+0.6%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bincommon/commonflags.go Outdated Show resolved Hide resolved
bincommon/commonflags.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
fgrpc/pingsrv.go Show resolved Hide resolved
fortio_main.go Outdated Show resolved Hide resolved
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that user-agent thing sort of bothers me but we can figure it out later

@ldemailly ldemailly merged commit a2c22f1 into fortio:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting grpc metadata
2 participants