This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Switched to Styled Components #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed a minimal part of the application to see how it works.
They're nicer to read and write than the interpolated functions.
Unfortunately it seems that composition with `css` doesn't work that well with typescript. These are things which make sense to be composed or extended. Composition will be used carefully because of this.
It now uses a few new things.
It doesn't seem to help the typescript errors.
It was already encapsulated properly so this was an easy change.
Styled components are delightful. Also changed to use a named export and renamed the backgroundInteraction prop.
SliderInput was a bit hairy because typings doesn't work correctly when extending an input range. Bars is hevily intertwined in many places making refactoring hard.
It previously wasn't working with interpolated values. It also makes sense as a mixin.
Slider wasn't necessary. SliderInput doesn't use a container element.
Before this pranch is merged, the theme situtation should be figured out. I've wasted too much time trying to figure out why my stories are broken when the theme provider is missing.
They're not used right now. They can be added back when needed later.
I don't really think it is needed anymore.
It was being used for very little so just inlined the parts which were being used.
Closed
AzureMarker
approved these changes
Aug 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to Styled Components. I think they are a better way to write css for the reasons outlined in #50. Also added the bootstrap container. It allows us to remove CSS Modules and postcss which bring us a step closer to un-ejecting (#14).
Closes #50
Closes #29