Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8280: Fixed setting incorrect option label #5582

Merged
merged 1 commit into from Apr 30, 2024

Conversation

roma-formio
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8280

Description

It was an incorrect order of resolvers to get select data, as it was trying to get selectData from select component settings in the first order, it always returns selectData from the form configuration instead of selectData from the metadata. Just fixed the order.

How has this PR been tested?

Unit test

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit d9d5c3e into master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants