Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8199: Fixes an issue where Checkbox does not have id and for attributes #5581

Open
wants to merge 7 commits into
base: 4.19.x
Choose a base branch
from

Conversation

alexandraRamanenka
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8199

Description

Added some missing attributes to the Checkbox component, the PR for 5.x renderer was created separetaly sue to the changes of the project structure and moving templates to the separate lib formio/bootstrap#92

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

Manually and automated tests are written

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@TanyaGashtold TanyaGashtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants