Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8091: Fixed missing metadata for html5 select component with defa… #5579

Merged
merged 1 commit into from Apr 26, 2024

Conversation

roma-formio
Copy link
Contributor

…ult value

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8091

Description

The issue was that the select component had the logic to set metadata inside the normalizeSingleValue method and for html5 select component with default value this part was unreachable. As the normalizeSingleValue method is supposed to return the correct value based on type, it shouldn't contain any side effects like set metadata. In that case, I moved that logic to the separate setMetadata method and using it only when the select component is trying to update the value.

How has this PR been tested?

Unit tests

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 65bf3d5 into master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants