Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add mac to CI #2717

Merged
merged 2 commits into from Mar 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-pr.yml
Expand Up @@ -6,7 +6,7 @@ jobs:
build:
strategy:
matrix:
os: [ubuntu-18.04]
os: [ubuntu-18.04, macos-latest]
runs-on: ${{ matrix.os }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Expand Up @@ -6,7 +6,7 @@ jobs:
build:
strategy:
matrix:
os: [ubuntu-18.04]
os: [ubuntu-18.04, macos-latest]
runs-on: ${{ matrix.os }}

steps:
Expand Down
10 changes: 5 additions & 5 deletions README.md
Expand Up @@ -21,23 +21,23 @@ git submodule init
git submodule update
```

Now you can build & test with yarn:
Now you can build & test with `npm`:

```sh
yarn && yarn build && yarn test
npm i && npm run build && npm run test
```

To run examples:

```sh
yarn examples
npm run examples
```

To build/test individual package:

```sh
yarn bazel build //packages/react-intl
yarn bazel test //packages/react-intl
bazel build //packages/react-intl
bazel test //packages/react-intl
```

Releases can be done with the following steps (**must use `npm`**):
Expand Down
8 changes: 4 additions & 4 deletions WORKSPACE
Expand Up @@ -43,7 +43,7 @@ http_archive(
urls = ["https://data.iana.org/time-zones/releases/tzcode%s.tar.gz" % IANA_TZ_VERSION],
)

load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "npm_install")

node_repositories(
node_version = "14.9.0",
Expand Down Expand Up @@ -81,14 +81,14 @@ http_archive(
],
)

# The yarn_install rule runs yarn anytime the package.json or yarn.lock file changes.
# The npm_install rule runs yarn anytime the package.json or yarn.lock file changes.
# It also extracts and installs any Bazel rules distributed in an npm package.

yarn_install(
npm_install(
# Name this npm so that Bazel Label references look like @npm//package
name = "npm",
package_json = "//:package.json",
yarn_lock = "//:yarn.lock",
package_lock_json = "//:package-lock.json",
)

# Setup skylib
Expand Down