fix(ts-transformer): allow to override user defined message id via overrideIdFn
as function
#1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can define
overrideIdFn
as a function that receives msg.id as the first argument.BUT according to current logic, this function will be never called. And users aren't able to modify already defined id. For example, I want to globally add prefixes to all ids. But cannot do it right now.
This PR fixes this issue.
So current logic will be:
overrideIdFn
is a stringmsg.id
is defined leave it unchangedmsg.id
is empty then useinterpolateName
with provided templateoverrideIdFn
is a functionmsg.id
to function as first arg. Allow to user decide what to do with id - it may be empty or contain already defined value