Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PropType of Formatted{,HTML}Message to accept any component #1228

Closed
wants to merge 1 commit into from
Closed

Fix PropType of Formatted{,HTML}Message to accept any component #1228

wants to merge 1 commit into from

Commits on Jan 7, 2019

  1. Fix PropType of Formatted{,HTML}Message to accept any component 

    A React component is not the same as a React element! In our case,
the tagName prop can be anything that can be passed to
React.createElement(). Unfortunately the prop-types package doesn't
provide a suitable validation function, so people are forced to build
their own.

See facebook/prop-types#200 for a related
discussion.
    @wereHamster
    wereHamster committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    3f2d8f6 View commit details
    Browse the repository at this point in the history