Upgrade omniauth-github to fix Github login deprecation notice #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
requested review from
a team,
atsmith813 and
nickytonline
and removed request for
a team
joshpuetz
approved these changes
Feb 11, 2020
pr-triage
bot
added
PR: reviewed-approved
atsmith813
approved these changes
Feb 11, 2020
|
Sorry @vaidehijoshi, I forgot about the issue :( Going to update the description so it automatically fixes it! |
|
@rhymes thanks so much for doing this! i just got that GitHub email again yesterday, so this is really great timing 🤗 |
vaidehijoshi
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
This looks okay to me! I didn't test it out locally but looking at the other changes in 1.4.0, they appear relatively minor aside from the headers change.
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Recently both @ludwiczakpawel and I received a deprecation email from GitHub as they are changing the way the HTTP clients are supposed to send authentication params (yes to headers, no to URL params).
This is the deprecation notice:
Tested this manually, it works
NOTE: Octokit, Github's client, has already been upgraded to a correct version: https://github.com/octokit/octokit.rb/releases/tag/v4.16.0
Related Tickets & Documents
Closes #5899