Update rubyzip to 1.3.0 to fix vulnerability #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightalloy
reviewed
Sep 30, 2019
| @@ -76,7 +76,7 @@ gem "redcarpet", "~> 3.5" # A fast, safe and extensible Markdown to (X)HTML pars | |||
| gem "reverse_markdown", "~> 1.3" # Map simple html back into markdown | |||
| gem "rolify", "~> 5.2" # Very simple Roles library | |||
| gem "rouge", "~> 3.10" # A pure-ruby code highlighter | |||
| gem "rubyzip", "~> 1.2" # Rubyzip is a ruby library for reading and writing zip files | |||
| gem "rubyzip", "~> 1.2", ">= 1.3.0" # Rubyzip is a ruby library for reading and writing zip files | |||
There was a problem hiding this comment.
Why not just gem "rubyzip", ">= 1.3.0" ? 🤔
There was a problem hiding this comment.
Honestly, no particular reason, the algorithm works the same I think, see the line with Rails and other gems with the same double rule
maestromac
approved these changes
Sep 30, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Aswathprabhu
pushed a commit
to Aswathprabhu/dev.to
that referenced
this pull request
Sep 30, 2019
Aswathprabhu
pushed a commit
to Aswathprabhu/dev.to
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
There's a vulnerability about entry sizes during extraction in rubyzip that has been fixed both in versions 1.3.0 and 2.0
Related Tickets & Documents
rubyzip/rubyzip#403
Added to documentation?