Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby from 3.0.2 to 3.0.4 #17416

Closed
wants to merge 1 commit into from
Closed

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 25, 2022

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What type of PR is this? (check all applicable)

  • Optimization

Description

Updates Ruby from 3.0.2 to 3.0.4 as well as (default) bundler from 2.2.22 to 2.2.33.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

n/a

Added/updated tests?

  • I need help with writing tests

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir requested a review from a team April 25, 2022 07:28
@tnir tnir requested a review from a team as a code owner April 25, 2022 07:28
@tnir tnir requested review from a team and maestromac and removed request for a team April 25, 2022 07:28
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 25, 2022
@tnir tnir requested review from Zhao-Andy, juliannatetreault and phannon716 and removed request for a team April 25, 2022 07:28
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@jeremyf
Copy link
Contributor

jeremyf commented Apr 25, 2022

@tnir Thanks for the submission, we're looking into the details of upgrading the fleet's build process.

@tnir
Copy link
Contributor Author

tnir commented Apr 28, 2022

@jeremyf Can I help you add forem/ruby:3.0.4 to https://quay.io/repository/forem/ruby?tab=tags? It does not look like an open source...

@jeremyf
Copy link
Contributor

jeremyf commented Apr 28, 2022

@tnir I'm raising this to the SRE/Devops folks as their the ones that have been tracking this work.

@maestromac
Copy link
Contributor

maestromac commented May 2, 2022

@tnir We are using Fedora's system ruby and they currently do not support 3.0.4 but it looks like it will be releasing very soon.

@aitchiss aitchiss marked this pull request as draft May 9, 2022 09:16
@aitchiss
Copy link
Contributor

aitchiss commented May 9, 2022

@tnir We are using Fedora's system ruby and they currently do not support 3.0.4 but it looks like it will be releasing very soon.

Just a heads up I've converted this PR to draft for now since we're waiting on the Fedora support

@tnir
Copy link
Contributor Author

tnir commented May 12, 2022

@maestromac @aitchiss Thanks for feedback. Due to #17645, let me close this now.

I am not familiar with general development workflow with Fedora and RedHat Quay and new to Forem's internal development workflow, but Fedora 36 is going with Ruby 3.1 so closing while I already have noticed that Fedora 34 and 35 have ruby-3.0.4-based packages in their testing repositories, respectively. 🙏 😭 👋

@tnir tnir closed this May 12, 2022
@pr-triage pr-triage bot added PR: draft bot applied label for PR's that are a work in progress and removed PR: unreviewed bot applied label for PR's with no review labels May 12, 2022
@tnir tnir deleted the tnir/ruby-3.0.4 branch May 12, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: draft bot applied label for PR's that are a work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants