Update @testing-library/cypress from 7.0.7 to 8.0.2

[tnir]

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What type of PR is this? (check all applicable)

• Refactor
• Optimization

Description

Revisits upgrading @testing-library/cypress npm package from 7.x to 8.x, @rhymes stopped in #14403 (comment) .

The PR #14324 contained a version bump to pretty-format@27.0.6 which required a later version of node than our buildkite builds can currently use. As a result, all of our latest buildkite builds are failing with the error:

error pretty-format@27.0.6: The engine "node" is incompatible with this module. Expected version "^10.13.0 \|\| ^12.13.0 \|\| ^14.15.0 \|\| >=15.0.0". Got "14.14.0"
--
  | error Found incompatible module.

This PR reverts the change until we are able to upgrade the node version in buildkite (this is a work in progress with systems team)

Cited from #14353

This update avoids to use @testing-library/dom 7.x, which depends on pretty-format 26.x. After this patch, only @testing-library/preact depends on @testing-library/dom 7.x, which will be resolved in testing-library/preact-testing-library#49.

Related Tickets & Documents

• Related PRs: Revert "Bump @testing-library/cypress from 7.0.6 to 8.0.0 (#14324)" #14353, Bump @testing-library/cypress from 7.0.6 to 8.0.0 #14403
  • Bump @testing-library/cypress from 7.0.6 to 8.0.0 #14324
• Breaking changes on upstream: https://github.com/testing-library/cypress-testing-library/releases/tag/v8.0.0
  • including Drop Node 10 support testing-library/cypress-testing-library#188
• chore: update @testing-library dependencies testing-library/preact-testing-library#49

QA Instructions, Screenshots, Recordings

n/a

UI accessibility concerns?

n/a

Added/updated tests?

• No, and this is why: dep (npm) updated

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[tnir]

Looping in @rhymes and @aitchiss

[aitchiss]

Nicely spotted!

Given the build has passed with no issues, I think that's all we need to know here 😄

[tnir]

@aitchiss Thanks. Are you still using buildkite? It looks like no more check in GitHub Checks to me.

[aitchiss]

@aitchiss Thanks. Are you still using buildkite? It looks like no more check in GitHub Checks to me.

It doesn't run on all builds 🤔 I think we are OK though - the original problem was our Node version in buildkite was too low, but it's since been bumped to 16.x so we should be alright 🙌

[tnir]

memo: Only when a team member triggers, we would see the check:

forem/.github/workflows/buildkite.yml

Lines 3 to 8 in a489407

	issue_comment:
	types: [created]
	jobs:
	add_ci_label:
	name: "Add CI label to pull request"
	if: github.event.issue.pull_request != '' && contains(github.event.comment.body, '/ci') && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'CONTRIBUTOR')