Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile.lock for Bundler 2.2 #12272

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

citizen428
Copy link
Contributor

@citizen428 citizen428 commented Jan 14, 2021

What type of PR is this? (check all applicable)

  • Bug Fix

Description

After upgrading to Bundler 2.2 locally, I had problems bundling on Linux. This is caused by older bundler versions not recording platform-specific information in the lockfile, but trying to resolve it at installation time instead. I explicitly added support for x86_64-linux with bundle lock --add-platform x86_64-linux and can now bundle again.

See this issue for context, specifically this comment outlining the problem and this comment with the solution.

Related Tickets & Documents

n/a

QA Instructions, Screenshots, Recordings

Install Bundler 2.2 on Linux and verify that you can successfully run bundle install, especially bundle install --local.

UI accessibility concerns?

n/a

Added tests?

  • No, and this is why: no code changes

Added to documentation?

  • No documentation needed

@citizen428 citizen428 requested a review from a team January 14, 2021 07:07
@citizen428 citizen428 requested a review from a team as a code owner January 14, 2021 07:07
@citizen428 citizen428 requested review from Ridhwana and removed request for a team January 14, 2021 07:07
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 14, 2021
Copy link
Contributor

@Ridhwana Ridhwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can'r really test this but the changes don't look damaging 😅

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 14, 2021
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Jan 14, 2021
@maestromac maestromac merged commit 36714f0 into master Jan 14, 2021
@maestromac maestromac deleted the citizen428/bundler-2.2 branch January 14, 2021 13:28
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants