Optimization: Upgrade Puma to 5.0.2 #10928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
pr-triage
bot
added
PR: unreviewed
benhalpern
approved these changes
Oct 19, 2020
pr-triage
bot
added
PR: partially-approved
maestromac
approved these changes
Oct 19, 2020
citizen428
approved these changes
Oct 20, 2020
|
This is good to go @mstruve if you want to merge it to observe any little changes to prod that might happen. |
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The problems we were seeing in Heroku with the original Puma 5 gem upgrade look to have been resolved.
In addition, this broke our container builds. Since upgrading I rebuilt and launched a new Docker container without an issue.
Related Tickets & Documents
https://github.com/orgs/forem/projects/6#card-45908891
QA Instructions, Screenshots, Recordings
Build and launch a docker container.