Revert "Bump puma from 4.3.6 to 5.0.0" #10413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9308c8b.
mstruve
requested review from
citizen428 and
jdoss
and removed request for
a team and
nickytonline
jdoss
approved these changes
Sep 21, 2020
pr-triage
bot
added
PR: partially-approved
Zhao-Andy
approved these changes
Sep 21, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10393
Reverting this PR bc
Looks like the new puma gem (5.0.0) breaks our container builds. I am looking into it
We are also seeing a lot of the Puma::ConnectionError 's in our logs on Datadog which according to a recent issue seems to be a common problem. The app seems to be OK but this makes me a little leery and since container builds are broken I am going to roll it back.