Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-5067151: Update request-light and eslint dependencies for security patches #495

Closed
wants to merge 2 commits into from

Conversation

allileong
Copy link
Contributor

What does this PR do?

This pr updates the version numbers for our request-light and eslint dependencies.

What issues does this PR fix or reference?

The updates include fixes for security vulnerabilities found by Snyk.

@DatGuyJonathan
Copy link
Contributor

Snyk doesn't run on top level node_modules, but I think the eslint version should be updated as well for consistency: https://github.com/forcedotcom/salesforcedx-vscode/blob/develop/package.json#L5

@vazexqi
Copy link
Contributor

vazexqi commented Jun 19, 2018

"Snyk doesn't run on top level node_modules" <-- We can make it run on the top-level ones as well. Perhaps we should do that?

@vazexqi
Copy link
Contributor

vazexqi commented Jun 19, 2018

lerna ERR! npm WARN ajv-keywords@2.1.1 requires a peer of ajv@^5.0.0 but none is installed. You must install peer dependencies yourself.
lerna ERR! 
lerna ERR! Error: Command failed: npm list --production --parseable --depth=99999
lerna ERR! npm ERR! peer dep missing: ajv@^5.0.0, required by ajv-keywords@2.1.1

This one looks serious. Might be related to #322 where we also hit an issue with ajy. If CircleCI doesn't pass, that means that we won't be able to package and publish.

@vazexqi
Copy link
Contributor

vazexqi commented Jun 20, 2018

By the way, @allileong (and anyone else contributing), we have a preference on how we structure the git commit messages. See https://chris.beams.io/posts/git-commit/ I realized I never made that explicit but it's good to write it down. I will make a PR to the docs folder to include that.

So usually we don't include the bug number in the subject/title so that it's easier to make sense of what a PR is without having to think about bug numbers.

We can discuss more when I send the PR on the preference of git messages (think of it as a request-for-comments).

@allileong allileong closed this Aug 23, 2018
@allileong allileong deleted the aleong/minorUpdates branch December 5, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants