Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build vscode packages on CircleCI nightly regardless of commits #340

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

vazexqi
Copy link
Contributor

@vazexqi vazexqi commented Mar 8, 2018

What does this PR do?

There were two occasions where an upstream changed not related to our changes broke the vscode:package step. This was in #322, #332, and #333. When it happened, we basically only found out about it a few days later and had to quickly fix it.

It would be good to have a nightly build on Circle CI that executes that step so that we can find out about any errors earlier.

I've chosen to use CircleCI since right now, it's very lean. It's only running the build of vscode:package. Also, CircleCI has been configured to e-mail me (anyone else can sign up) so that you get notifications when the build passes/fails.

What issues does this PR fix or reference?

Build stability.

@@ -67,9 +67,6 @@ test_script:
}
- npm run coverage:system-tests

after_test:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's save some cycles off AppVeyor since we are also doing this on CircleCI for now.

- build
scheduled-workflow:
triggers:
- schedule:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a filter to run on a specific branch or is that part of the config of the job already ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcampos - Good question. It's for all branches now. The syntax allows us to limit it. See https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow

I'll limit it to develop (and master since we might need to do e-releases from there).

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #340 into develop will increase coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
+ Coverage    76.51%   77.73%   +1.21%     
===========================================
  Files          132      132              
  Lines         5007     5007              
  Branches       787      787              
===========================================
+ Hits          3831     3892      +61     
+ Misses         980      918      -62     
- Partials       196      197       +1
Impacted Files Coverage Δ
...orcedx-apex-debugger/src/core/breakpointService.ts 91.2% <0%> (+1.09%) ⬆️
...rcedx-apex-debugger/src/commands/requestService.ts 82.92% <0%> (+2.43%) ⬆️
...alesforcedx-apex-debugger/src/adapter/apexDebug.ts 86.21% <0%> (+3.64%) ⬆️
...esforcedx-apex-debugger/src/core/sessionService.ts 93.33% <0%> (+6.66%) ⬆️
...sforcedx-apex-debugger/src/core/streamingClient.ts 85.71% <0%> (+33.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f170d...9391e0b. Read the comment docs.

Copy link
Contributor

@lcampos lcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vazexqi vazexqi merged commit 27da290 into develop Mar 9, 2018
@vazexqi vazexqi deleted the nick/circle-ci-nightly-builds branch March 9, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants