-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build vscode packages on CircleCI nightly regardless of commits #340
Conversation
@@ -67,9 +67,6 @@ test_script: | |||
} | |||
- npm run coverage:system-tests | |||
|
|||
after_test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's save some cycles off AppVeyor since we are also doing this on CircleCI for now.
- build | ||
scheduled-workflow: | ||
triggers: | ||
- schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a filter to run on a specific branch or is that part of the config of the job already ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lcampos - Good question. It's for all branches now. The syntax allows us to limit it. See https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow
I'll limit it to develop (and master since we might need to do e-releases from there).
Codecov Report
@@ Coverage Diff @@
## develop #340 +/- ##
===========================================
+ Coverage 76.51% 77.73% +1.21%
===========================================
Files 132 132
Lines 5007 5007
Branches 787 787
===========================================
+ Hits 3831 3892 +61
+ Misses 980 918 -62
- Partials 196 197 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
There were two occasions where an upstream changed not related to our changes broke the
vscode:package
step. This was in #322, #332, and #333. When it happened, we basically only found out about it a few days later and had to quickly fix it.It would be good to have a nightly build on Circle CI that executes that step so that we can find out about any errors earlier.
I've chosen to use CircleCI since right now, it's very lean. It's only running the build of
vscode:package
. Also, CircleCI has been configured to e-mail me (anyone else can sign up) so that you get notifications when the build passes/fails.What issues does this PR fix or reference?
Build stability.