Drop support Python 3.7, run tests on Python 3.11 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah yes, no windows 3.11 wheels yet for lxml ... :-/ |
FontTools has dropped support for 3.7, thus we follow suit fonttools/fonttools#2879 fonttools/fonttools#2878
…llections.abc Fixes TypeError on Python 3.8 https://github.com/fonttools/ufoLib2/actions/runs/3404749253/jobs/5662213808
No longer needed since we target >= 3.8 now
khaledhosny
force-pushed
the
drop-py37
branch
from
011b183
to
36684d4
Compare
|
I fixed some mypy errors, the remaining ones are all Greek to me. |
I don’t understand what these are: src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes], NamedArg(Callable[..., _T]), KwArg(Any)], _T]" [arg-type] src/ufoLib2/serde/__init__.py:91: note: This is likely because "_loads" has named arguments: "cls". Consider marking them positional-only src/ufoLib2/serde/__init__.py:91: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[str, bytes], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes], NamedArg(Callable[..., Any]), KwArg(Any)], Any]" [arg-type] src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[_T], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., _T]), KwArg(Any)], _T]" [arg-type] src/ufoLib2/serde/__init__.py:96: note: This is likely because "_load" has named arguments: "cls". Consider marking them positional-only src/ufoLib2/serde/__init__.py:96: error: Argument 1 to "classmethod" has incompatible type "Callable[[Type[T], Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[AnyStr]], NamedArg(Callable[..., T]), KwArg(Any)], T]"; expected "Callable[[Type[Any], Union[str, bytes, PathLike[str], PathLike[bytes], IO[AnyStr]], NamedArg(Callable[..., Any]), KwArg(Any)], Any]" [arg-type]
|
Ignored the remaining two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontTools has dropped support for 3.7, thus we follow suit
fonttools/fonttools#2879
fonttools/fonttools#2878