[instancer] CFF2 instancing #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behdad
force-pushed
the
cff2-instancing
branch
4 times, most recently
from
93092bc
to
34170eb
Compare
|
I put the blends into the VarStore, instantiate that, and rebuild the blends from it. Since we have code to instantiate VarStore, it works nicely. |
|
behdad
force-pushed
the
cff2-instancing
branch
3 times, most recently
from
cdea0d1
to
6e8891b
Compare
|
Did the advance widths. |
Down to this now... |
|
Oh, and pruning the VarStore; and dropping vsindex when not needed and VarStore when not needed. |
gvar is removed by the time we get to hmtx/vmtx subsetting.
vsindex 0 is implied. Also, add Unimplemented code for private-dict variable values. I couldn't find any fonts using them, so for now they remain unimplemented.
Done. |
I know how to do it. But can't find any fonts using those. So, for now, I left it unimplemented error. I think this PR is ready. Volunteers for tests needed. |
|
We might also want to downgrade to CFF if static instancing. |
As well as actually save!
Also drop explicit width. See comments.
Otherwise it fails for charset fonts.
anthrotype
reviewed
May 17, 2024
anthrotype
reviewed
May 17, 2024
anthrotype
reviewed
May 17, 2024
anthrotype
reviewed
May 17, 2024
anthrotype
reviewed
May 17, 2024
anthrotype
reviewed
May 17, 2024
anthrotype
approved these changes
May 17, 2024
Co-authored-by: Cosimo Lupo <cosimo@anthrotype.com>
They can't be decompiled standalone. Decompiling glyph programs already decompiled the used ones.
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Almost there.