New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instancer] Start avar2 instancing #3485
base: main
Are you sure you want to change the base?
Conversation
Just thinking out loud, this is what I think so far:
Because of the above, I wrote the code that taken axis limits, tells you what the min/max of each axis can be in the VarStore. Eg.:
Problem arises if the user wants to modify these hidden axes as well. Then it's not clear if we should limit their range or not :(. But I'd argue that the parametric axes in RobotoFlex and alike should be public, not private. The code above is not complete to compute new axis extents though. Remember that we add the delta for the axis to its currently set value. So the code should take that into consideration. In which case, eg, After deciding the normalized new range of each axis, we need to work them back from the avar1-segments to get new fvar values. And then build a new varStore for axes that scales the individual values based on the new axis extents. That's my thinking. |
@davelab6 We really need those avar2 test fonts for various use-cases... |
cc @anthrotype |
7fce9f4
to
d66ad1d
Compare
Just some code for now to get min/max delta of a varIdx from a varStore...
It's constant.
Seems to be working now.
This kinda seems to work now, even though it's not complete. I need testers like @Lorp |
Seems to do something.
Just some code for now to get min/max delta of a
varIdx from a varStore...