Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ttFont] Add reorderGlyphs #3468

Merged
merged 2 commits into from Mar 30, 2024
Merged

[ttFont] Add reorderGlyphs #3468

merged 2 commits into from Mar 30, 2024

Conversation

behdad
Copy link
Member

@behdad behdad commented Mar 28, 2024

Fixes #2060

Manually tested; need to add real tests.

@behdad behdad force-pushed the reorderGlyphs branch 2 times, most recently from d58c423 to 561a0e7 Compare March 28, 2024 17:55
@behdad
Copy link
Member Author

behdad commented Mar 29, 2024

Do we have any volunteers to write a test?

@khaledhosny
Copy link
Collaborator

I can work on a test.

@behdad
Copy link
Member Author

behdad commented Mar 30, 2024

Thank you.

@behdad
Copy link
Member Author

behdad commented Mar 30, 2024

Beautiful. Thank you.

@behdad behdad merged commit fae8744 into main Mar 30, 2024
11 checks passed
@behdad behdad deleted the reorderGlyphs branch March 30, 2024 23:22
@behdad behdad mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaledhosny khaledhosny khaledhosny approved these changes

@rsheeter rsheeter rsheeter approved these changes

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issues while attempting to reorder glyphs in a TTFont
3 participants
@behdad @khaledhosny @rsheeter